I am trying to use a runnable to count down from 30s to 0, then run a method, then restart. I cannot seem to get this working right. Seems like a very convoluted solution for a simple task...
tvHeatCD is a TextView that should update every sec to show "5s" if 5 seconds remain etc
reduceHeat() is the method that should run every 30 seconds (matching conditions shown)
stopHeatTimer() is just calling handler.removeCallbacks(..) and heatTimerRunning = false
public void checkHeatTimer() {
RealmResults<Heat> heatList = realm.where(Heat.class).equalTo("theheat","theheat").findAll();
ht = heatList.get(0);
if(ht.getHeat() !=0) {
if(!heatTimerRunning) {
final int[] countdown = {30};
tvHeatCD.setVisibility(View.VISIBLE);
heatRunnable = new Runnable() {
#Override
public void run() {
heatTimerRunning = true;
if (!realm.isClosed()) {
countdown[0]--;
if(countdown[0] == 0) {
if (ht.getHeat() != 0) {
Crashlytics.setInt("heat", ht.getHeat());
reduceHeat("normal",20);
stopHeatTimer();
checkHeatTimer();
} else {
Crashlytics.setInt("heat", 0);
tvHeatCD.setVisibility(View.GONE);
stopHeatTimer();
}
}
tvHeatCD.setText(countdown[0] + "s");
heatHandler.postDelayed(heatRunnable, 1000);
} else if (realm.isClosed()) {
recreate();
}
}
};
heatHandler.postDelayed(heatRunnable, 30000);
}
} else {
tvHeatCD.setVisibility(View.GONE);
}
}
Appreciate any help...thank you!
This question already has answers here:
Accessing views from other thread (Android)
(5 answers)
Closed 4 years ago.
in a tuner application on which I am working right now, I wanted to implement an Indicator which shows if the right pitch is played. For this I have implemented that the color of the indicator only changes when I hold the pitch for atleast 2 seconds.
public void thr(final double v1, final double v2) {
new Thread() {
#Override
public void run() {
super.run();
int i = 0;
while (pitchInHz >= v1 && pitchInHz < v2) {
if(i == 20){ //2 Sekunden
imageView.setBackgroundColor(getResources().getColor(holo_green_light));
}else {
imageView.setBackgroundColor(getResources().getColor(darker_gray));
try {
sleep(100);
} catch (InterruptedException e) {
e.printStackTrace();
}
i++;
}
}
running = false;
}
}.start();
Everytime my application tries to use the thread, the app just crashes.
some ideas why this is happening?
if(pitchInHz >= 72.41 && pitchInHz < 92.41) {
//e
noteText.setText("e"); //this is working
if(!running) {
thr(72.41, 92.41);
running = true;
}
I'm supposing it's because you're trying to access a view from a different thread than the main thread, which you cannot do such thing.
Try running like this:
public void thr(final double v1, final double v2) {
new Thread() {
#Override
public void run() {
super.run();
int i = 0;
while (pitchInHz >= v1 && pitchInHz < v2) {
if(i == 20){ //2 Sekunden
runOnUiThread(new Runnable() {
#override
public void run() {
imageView.setBackgroundColor(getResources().getColor(holo_green_light));
}
})
}else {
runOnUiThread(new Runnable() {
#override
public void run() {
imageView.setBackgroundColor(getResources().getColor(darker_gray));
}
})
try {
sleep(100);
} catch (InterruptedException e) {
e.printStackTrace();
}
i++;
}
}
running = false;
}
}.start();
So hi everyone, this is my first post in stackoverflow,
and i get stucked in 1 problem,
the problem is:
how can I add a delay inside for loop
I did lots of research and none of it works
So I decided to ask myself.
Here is my code
Handler handler1 = new Handler();
for (langId = 1; langId <= 3; langId++) {
handler1.postDelayed(new Runnable() {
#Override
public void run() {
if (langId == 1) {
Toast.makeText(KCRdestActivity.this, "1", Toast.LENGTH_LONG).show();
delayTime += 2000;
}
if (langId == 2) {
Toast.makeText(KCRdestActivity.this, "2", Toast.LENGTH_LONG).show();
delayTime += 2000;
}
if (langId == 3) {
Toast.makeText(KCRdestActivity.this, "3", Toast.LENGTH_LONG).show();
delayTime += 2000;
}
}
}, delayTime);
}
So the result I want is:
"1" -> 2000ms -> "2" -> 2000ms -> "3"
Any ideas?
I tried Thread.sleep(2000), it works, but it freeze the app, I need to do extra things during the process.
Edit
Problem solved, this is the working code, also my final goal
playBtn2.setOnClickListener(new View.OnClickListener() {
#Override
public void onClick(View v) {
final Handler handler1 = new Handler();
langId = 1;
max = 1;
delayTime = 0;
selectedMP = 1;
if (((RadioButton) findViewById(R.id.noneDepart)).isChecked()) max = 3;
else max = 6;
handler1.post(new Runnable() {
#Override
public void run() {
if (((RadioButton) findViewById(R.id.noneDepart)).isChecked()) {
String destdir = "KCR/Depart/" + Utils.getDestID(selectedDest) + "_";
if (viaRAC.isChecked()) destdir = destdir + "via_rac_";
destdir = destdir + langId + ".mp3";
if (selectedMP == 1) {
try {
afd = getAssets().openFd(destdir);
mp1.reset();
mp1.setDataSource(afd.getFileDescriptor(), afd.getStartOffset(), afd.getLength());
mp1.prepare();
mp1.start();
//Utils.RunOnUiThread(KCRdestActivity.this, mp1, sb1);
((Button) findViewById(R.id.Play1)).setText("❙❙");
selectedMP = 2;
delayTime = mp1.getDuration() - 130;
Toast.makeText(KCRdestActivity.this, delayTime + "##" + destdir, Toast.LENGTH_LONG).show();
} catch (Exception e) {
e.printStackTrace();
}
} else {
try {
afd = getAssets().openFd(destdir);
mp2.reset();
mp2.setDataSource(afd.getFileDescriptor(), afd.getStartOffset(), afd.getLength());
mp2.prepare();
mp2.start();
//Utils.RunOnUiThread(KCRdestActivity.this, mp1, sb1);
((Button) findViewById(R.id.Play1)).setText("❙❙");
selectedMP = 1;
delayTime = mp2.getDuration() - 130;
Toast.makeText(KCRdestActivity.this, delayTime + "##" + destdir, Toast.LENGTH_LONG).show();
} catch (Exception e) {
e.printStackTrace();
}
}
}
if (langId > 3) {
return;
}
langId++;
handler1.postDelayed(this, delayTime);
}
});
}
});
Handler handler1 = new Handler();
int langId = 1;
handler1.postDelayed(new Runnable() {
#Override
public void run() {
if (langId > 3) {
return;
}
if (langId == 1) {
Toast.makeText(KCRdestActivity.this, "1", Toast.LENGTH_LONG).show();
delayTime = 2000;
}
if (langId == 2) {
Toast.makeText(KCRdestActivity.this, "2", Toast.LENGTH_LONG).show();
delayTime = 2000;
}
if (langId == 3) {
Toast.makeText(KCRdestActivity.this, "3", Toast.LENGTH_LONG).show();
delayTime = 2000;
}
langId++;
handler1.postDelayed(this, delayTyme);
}
}
There's no need to write that much lines of code, try this:
Handler handler1 = new Handler();
int langId = 1;
handler1.post(new Runnable() {
#Override
public void run() {
if (langId > 3) {
return;
}
Toast.makeText(KCRdestActivity.this, String.valueOf(langId++), Toast.LENGTH_LONG).show();
handler1.postDelayed(this, 2000); // If delay time is constant!
}
});
you can use asyntask along with Thread.sleep(2000) in the doInBackground method
try this..
MainActivity.....
long Delay = 2000;
oncreate().........
Timer Run = new Timer();
TimerTask Show = new TimerTask() {
#Override
public void run() {
do something.........
}
};
Run.schedule(Show, Delay);
}
You need to move your code out of run method and put into for loop directly. Put only toast inside run method.
1. Implement a timer task and schedule it after every 2seconds
int value = 1;
Timer timer = new Timer();
TimerTask task = new TimerTask() {
#Override
public void run() {
Toast.makeText(KCRdestActivity.this, value, Toast.LENGTH_LONG).show();
value++;
}
};
timer.schedule(task, 2000);
OR
2. Change your code to
Try
for (langId = 1; langId <= 3; langId++) {
delayTime += 2000;
Handler handler = new Handler();
handler.postDelayed(new Runnable() {
#Override
public void run() {
Toast.makeText(KCRdestActivity.this, String.valueOf(langId), Toast.LENGTH_LONG).show();
}
}, delayTime);
}
You can use an AsyncTask for this.
public class MyAsyncTask extends AsyncTask<Void, Integer, Void> {
#Override
protected Void doInBackground(Void... params) {
for (int langId = 1; langId <= 3; langId++) {
publishProgress(langId);
try {
Thread.sleep(2000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
return null;
}
#Override
protected void onProgressUpdate(Integer... values) {
super.onProgressUpdate(values);
Toast.makeText(KCRdestActivity.this, String.valueOf(values[0]), Toast.LENGTH_LONG).show();
}
}
use this method
declare global these classes
private int TIME_STAMP_INTERVAL = 2000;
private Runnable runnable = null;
private int count=0;
final Handler handler = new Handler();
then add this in method which u call
runnable = new Runnable() {
#Override
public void run() {
Toast.makeText(context, ""count++, Toast.LENGTH_SHORT).show();
handler.postDelayed(runnable, TIME_STAMP_INTERVAL);
}
};
handler.post(runnable);
A quick and dirty way to achieve this using Thread.sleep(2000):
public static void main(String[] args) {
Runnable forLoop = () -> {
for (int i = 1; i <= 3; i++) {
System.out.print(i); // Do your stuff
try {
Thread.sleep(2000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
};
new Thread(forLoop).start();
}
Output:
1 -> 2000ms -> 2 -> 2000ms -> 3
I'm trying to setup ProgressDialog to show to the user the progress of an InputStream of bytes. I'm able to show this in the console of the Android Studio by way of this below :
Log.d(TAG, "Progress, transferred " + Integer.toString(100 * bytesTransferred/osSize) + "%");
However, I'm not sure how to attach the bytesTransferred/osSize correctly to a ProgressDialog, I can use a thread to time how long the progress bar will take to fill up the progressBar with the code below:
update = new ProgressDialog(this);
update.setTitle("Transferring update");
update.setMessage("Please wait updating...");
update.setCanceledOnTouchOutside(false);
update.setProgress(0);
final int totalProgressTime = 100;
final Thread t = new Thread() {
#Override
public void run() {
int jumpTime = 0;
while(jumpTime < totalProgressTime) {
try {
sleep(1800);
jumpTime += 1;
update.setProgress(jumpTime);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
};
t.start();
update.setProgressStyle(ProgressDialog.STYLE_HORIZONTAL);
update.setButton(DialogInterface.BUTTON_NEGATIVE, "Cancel", new DialogInterface.OnClickListener() {
#Override
public void onClick(DialogInterface dialog, int which) {
dialog.dismiss();
}
});
update.show();
}
But would be much better to show to the user the actual transfer of the bytes. This below is what I have to work with:
final int osSize;
final InputStream inputStream;
osSize = inputStream();
public void onProgress(int bytesTransferred) {
Log.d(TAG, "Progress, transferred " + Integer.toString(100 * bytesTransferred/osSize) + "%");
}
Any help would be appreciated, thanks in advance.
Extend this:
#Override
public void run() {
int jumpTime = 0;
while(jumpTime < totalProgressTime) {
try {
sleep(1800);
jumpTime += 1;
update.setProgress(jumpTime);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
With this:
#Override
public void run() {
int jumpTime = 0;
while(jumpTime < totalProgressTime) {
try {
sleep(1800);
jumpTime += 1;
final int fJumpTime = jumpTime;
runOnUiThread(new Runnable() {
#Override
public void run() {
update.setProgress(fJumpTime);
});
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
Im a beginner android developer, so bear with me:
Im getting this error: "CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views"
Anyways, i have a media player with two threads, the first one updates a circular progress bar and the second one updates a text view that i want to use to show the time in the mp3 file. The first thread gives me no errors and runs perfectly fine. (I implemented this before the textview update)
The second thread however gives me the error in the title. I've looked into handlers asynctasks and runonuithread but I can't figure out how to utilize any of them since im using a while loop that's constantly updating it.
Also, why is only the second one giving me an error?
new Thread(new Runnable() {
#Override
public void run() {
ProgressBar myProgress = (ProgressBar) findViewById(R.id.circle_progress_bar);
int currentPosition = 0;
int total = mediaPlayer.getDuration();
myProgress.setMax(total);
while (mediaPlayer != null && currentPosition < total) {
try {
Thread.sleep(1000);
currentPosition = mediaPlayer.getCurrentPosition();
} catch (InterruptedException e) {
return;
} catch (Exception e) {
return;
}
myProgress.setProgress(currentPosition);
}
}
}).start();
new Thread(new Runnable() {
#Override
public void run() {
TextView currentTime = (TextView) findViewById(R.id.textView9);
int currentPosition = 0;
int total = mediaPlayer.getDuration();
while (mediaPlayer != null && currentPosition < total) {
try {
Thread.sleep(1000);
currentPosition = mediaPlayer.getCurrentPosition();
} catch (InterruptedException e) {
return;
} catch (Exception e) {
return;
}
currentTime.setText(getTimeString(currentPosition));
}
}
}).start();
And here's the code for getTimeString:
private String getTimeString(long millis) {
StringBuffer buf = new StringBuffer();
int hours = (int) (millis / (1000*60*60));
int minutes = (int) (( millis % (1000*60*60) ) / (1000*60));
int seconds = (int) (( ( millis % (1000*60*60) ) % (1000*60) ) / 1000);
buf
.append(String.format("%02d", hours))
.append(":")
.append(String.format("%02d", minutes))
.append(":")
.append(String.format("%02d", seconds));
return buf.toString();
}
do
myProgress.setMax(total);
in
runOnUIThread(new Runnable () {
#Override
public void run () {
myProgress.setMax(total);
}
});
Explanation
Views in android are only work/change/created on UI threads only. Other worker thread donot modify UI elements in Android, because Android is single threaded application.
You can also use AsyncTask which have onPreExecute() and onPostExecute() methods which run on UI thread to post updates to UI
As ρяσѕρєя K say, you can't update view in non-ui thread(Main Thread), so you can use a handler to finish this work
private Handler handler = new Handler() {
#Override
public void handleMessage(Message msg) {
// TODO : change currentTime and myProgress as a class number //
TextView currentTime = (TextView) findViewById(R.id.textView9);
ProgressBar myProgress = (ProgressBar) findViewById(R.id.circle_progress_bar);
if (msg.what == 0) {
currentTime.setText(getTimeString(msg.arg1));
} else if (msg.what == 1) {
myProgress.setProgress(msg.arg1);
}
}
};
Then in you two thread, replace
// myProgress.setProgress(currentPosition);
handler.obtainMessage(1, currentPosition, 0).sendToTarget();
// currentTime.setText(getTimeString(currentPosition));
// param1 -> msg.what, param2 -> msg.arg1, parm3 -> msg.arg2
handler.obtainMessage(0, currentPosition, 0).sendToTarget();
Do you Ui work in run On Ui thread :
example:
new Thread(new Runnable() {
#Override
public void run() {
int currentPosition = 0;
int total = mediaPlayer.getDuration();
while (mediaPlayer != null && currentPosition < total) {
try {
Thread.sleep(1000);
currentPosition = mediaPlayer.getCurrentPosition();
} catch (InterruptedException e) {
return;
} catch (Exception e) {
return;
}
runOnUIThread(new Runnable () {
#Override
public void run () {
ProgressBar myProgress = (ProgressBar) findViewById(R.id.circle_progress_bar);
myProgress.setMax(total);
myProgress.setProgress(currentPosition);
}
});
}
}
}).start();