Develop Reference

Problems with repaint() method in java

I'm new to Java and trying to make a simple Player vs. Computer "Tic-Tac-Toe" game using Swing. In the code I use paintComponent() method to paint certain components and call the repaint() method after the player or computer plays. The problem is that, the game freezes after the third (sometimes the second) time I click the mouse. In GameWindow class I create the instance of Map class.
public class GameWindow extends JFrame{
private final int sizeX = 3;
private final int sizeY = 3;
public GameWindow(){
setLocation(400,150);
setSize(406, 452);
setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
setResizable(false);
Map map = new Map(sizeX, sizeY);
add(map, BorderLayout.CENTER);
JPanel bottomPanel = new JPanel();
bottomPanel.setLayout(new GridLayout(1, 2));
add(bottomPanel, BorderLayout.SOUTH);
Button newGame = new Button("Новая игра");
newGame.addActionListener(new ActionListener() {
#Override
public void actionPerformed(ActionEvent e) {
System.out.println("Начинаем новую игру");
}
});
Button exit = new Button("Выход");
exit.addActionListener(new ActionListener() {
#Override
public void actionPerformed(ActionEvent e) {
System.exit(0);
}
});
bottomPanel.add(newGame);
bottomPanel.add(exit);
setVisible(true);
}
}
Here is the listener for the mouse click in the Map class:
public class Map extends JPanel {
private final int sizeX;
private final int sizeY;
private int cellWidth;
private int cellHeight;
private int cellX = -1;
private int cellY = -1;
private String lastPlayer = "nobody";
private String[][] table = new String[3][3];
public Map(int sizeX, int sizeY) {
this.sizeX = sizeX;
this.sizeY = sizeY;
setBackground(Color.WHITE);
for (int i = 0; i < table.length; i++) {
for (int j = 0; j < table.length; j++) {
table[i][j] = "empty";
}
}
addMouseListener(new MouseAdapter() {
#Override
public void mouseReleased(MouseEvent e) {
super.mouseReleased(e);
cellX = e.getX() / cellWidth;
cellY = e.getY() / cellHeight;
if (!winOrDraw()) {
boolean playerProgress = playerProgress();
if(playerProgress) {
botProgress();
}
}
}
});
}
Both in playerProgress() and botProgress() methods I call repaint() method to add new components to the screen. I can't really find out what is the problem in this code and why the program freezes after actually 6th call of repaint() method?
Here are winOrDraw(), playerProgress() and botProgress() methods:
private boolean winOrDraw(){
for (int i = 0; i < table.length; i++) {
if(table[i][0] == table[i][1] && table[i][1] == table[i][2] && !table[i][0].equals("empty")) return true;
else if(table[0][i] == table[1][i] && table[1][i] == table[2][i] && !table[0][i].equals("empty")) return true;
else if(table[0][0] == table[1][1] && table[1][1] == table[2][2] && !table[0][0].equals("empty")) return true;
else if(table[2][0] == table[1][1] && table[1][1] == table[0][2] && !table[2][0].equals("empty")) return true;
}
int i, j = 0;
for (i = 0; i < table.length; i++) {
for (j = 0; j < table.length; j++) {
if(table[i][j].equals("empty")) break;
}
}
if(i == table.length && j == table.length) { lastPlayer = "nobody"; return true; }
else return false;
}
private boolean playerProgress(){
if(!table[cellY][cellX].equals("empty")){
System.out.println("This cell is not empty");
return false;
} else {
lastPlayer = table[cellY][cellX] = "player";
repaint();
return true;
}
}
private void botProgress(){
do{
if(winOrDraw()){
switch (lastPlayer) {
case "player":
System.out.println("You won!");
System.exit(0);
case "bot":
System.out.println("Bot won");
System.exit(0);
default:
System.out.println("Draw");
System.exit(0);
}
}
Random random = new Random();
cellX = random.nextInt(2);
cellY = random.nextInt(2);
if(table[cellY][cellX].equals("empty")) {
lastPlayer = table[cellY][cellX] = "bot";
break;
}
}while (!table[cellY][cellX].equals("empty"));
System.out.println("Bot's turn");
repaint();
}

You are adding your Swing components directly to the JFrame-AWT-container. You should not do that. Instead you should do this:
JPanel panel = new JPanel();
myFrame.setContentPane(panel);
panel.setLayout(...)
panel.add(...);
panel.validate();
This should solve your problem.

Making a Simple RPG- Creating a new JFrame

I am making a 4-class RPG. It has Player class which allows us to move the player. It has Board class which is for the map in the game. There is a Battle class which is for the battle phase. RPG is the main class responsible for running the game.
What I want is the when the player comes to coordinates(500x500) I want the program to open a new window and it will have the JPanel of battle on it.
EDIT : Updated display() and actionPerformed() methods
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class Player {
private int dx,dy,x,y;
private Image image;
private ImageIcon front = new ImageIcon("player_front.png");
private ImageIcon left = new ImageIcon("player_left.png");
private ImageIcon right = new ImageIcon("player_right.png");
private ImageIcon back = new ImageIcon("player_back.png");
public Player() {
initplayer();
}
private void initplayer() {
image = front.getImage();
x = 0;
y = 0;
}
public void move() {
x += dx;
y += dy;
}
public int getX() {
return x;
}
public void setX(int x){
this.x = x;
}
public int getY() {
return y;
}
public void setY(int y) {
this.y = y;
}
public Image getImage() {
return image;
}
public void keyPressed(KeyEvent e) {
int key = e.getKeyCode();
dx = 0;
dy = 0;
if (key == KeyEvent.VK_LEFT && x >= 0) {
image = left.getImage();
dx = -1;
}
if (key == KeyEvent.VK_RIGHT && x <= 850) {
image = right.getImage();
dx = 1;
}
if (key == KeyEvent.VK_UP && y >= 0) {
image = back.getImage();
dy = -1;
}
if (key == KeyEvent.VK_DOWN && y <= 850) {
image = front.getImage();
dy = 1;
}
}
public void keyReleased(KeyEvent e) {
int key = e.getKeyCode();
if (key == KeyEvent.VK_LEFT) {
dx = 0;
}
if (key == KeyEvent.VK_RIGHT) {
dx = 0;
}
if (key == KeyEvent.VK_UP) {
dy = 0;
}
if (key == KeyEvent.VK_DOWN) {
dy = 0;
}
}
}
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class Board extends JPanel implements ActionListener {
private Battle battle;
private Timer timer;
private Player player;
private final int DELAY = 10;
private Image image;
private JLabel label;
public Board() {
initBoard();
}
private void initBoard() {
image = Toolkit.getDefaultToolkit().createImage("map.png");
addKeyListener(new TAdapter());
setFocusable(true);
player = new Player();
timer = new Timer(DELAY, this);
timer.start();
}
public Image getImage(){
return image;
}
#Override
public void paintComponent(Graphics g) {
super.paintComponent(g);
g.drawImage(image,0,0,null);
doDrawing(g);
}
private void doDrawing(Graphics g) {
Graphics2D g2d = (Graphics2D) g;
g2d.drawImage(player.getImage(), player.getX(), player.getY(), this);
}
public boolean checkBattle(){
if(player.getX() == 500 && player.getY() == 500){
return true;
}
return false;
}
public void actionPerformed(ActionEvent e) {//UPDATED
player.move();
if(checkBattle()){
battle.display();
}
repaint();
}
private class TAdapter extends KeyAdapter {
#Override
public void keyReleased(KeyEvent e) {
player.keyReleased(e);
}
#Override
public void keyPressed(KeyEvent e) {
player.keyPressed(e);
}
}
}
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.*;
public class Battle extends JPanel{
private JFrame frame;
private JPanel panel1, panel2;
private JLabel label1, label2, label3, label4;
private JButton button1, button2, button3, button4;
private int playerHealth = 100;
private int opponentHealth = 50;
private int maxOpponentHealth = 50;
private int level = 0;
private int playerDamage, opponentDamage, chance, levelDamage;
private ImageIcon image;
public Battle(){
setPreferredSize(new Dimension(500,500));
setLayout(new BorderLayout());
panel1 = new JPanel();
panel1.setLayout(new FlowLayout());
label1 = new JLabel("You : " + Integer.toString(playerHealth) + " / 100");
label2 = new JLabel("Opponent : " + Integer.toString(opponentHealth) + " / 50");
button1 = new JButton("Power Attack!(%50 hit chance)");
button2 = new JButton("Normal Attack!(%70 hit chance)");
button3 = new JButton("Quick Attack!(%90 hit chance)");
button4 = new JButton("NEXT LEVEL!");
panel2 = new JPanel();
ImageIcon image = new ImageIcon("player_vs_rival.png");
label4 = new JLabel(image);
ButtonListener listener = new ButtonListener();
button1.addActionListener(listener);
button2.addActionListener(listener);
button3.addActionListener(listener);
button4.addActionListener(listener);
panel1.add(button1);
panel1.add(button2);
panel1.add(button3);
panel1.add(button4);
panel2.add(label4);
label3 = new JLabel("");
add(label1, BorderLayout.WEST);
add(label2, BorderLayout.EAST);
add(label3, BorderLayout.SOUTH);
add(panel1, BorderLayout.CENTER);
add(panel2, BorderLayout.NORTH);
}
public void powerAttack(){
Random random = new Random();
playerDamage = random.nextInt(5) + 10;
}
public void normalAttack(){
Random random = new Random();
playerDamage = random.nextInt(10) + 5;
}
public void quickAttack(){
Random random = new Random();
playerDamage = random.nextInt(5) + 5;
}
public void opponentAttack(){
Random random = new Random();
opponentDamage = random.nextInt(5) + 5;
}
public boolean checkPowerAttack(){
Random random = new Random();
chance = random.nextInt(100);
if(chance >= 50){
return true;
}
return false;
}
public boolean checkNormalAttack(){
Random random = new Random();
chance = random.nextInt(100);
if(chance >= 30){
return true;
}
return false;
}
public boolean checkQuickAttack(){
Random random = new Random();
chance = random.nextInt(100);
if(chance >= 10){
return true;
}
return false;
}
public boolean checkOpponentAttack(){
Random random = new Random();
chance = random.nextInt(100);
if(chance >= 25){
return true;
}
return false;
}
public void levelDamage(){
Random random = new Random();
levelDamage = random.nextInt(5);
levelDamage = levelDamage * level;
}
public void display(){//UPDATED
JFrame newFrame = new JFrame("New Window");
Battle battle = new Battle();
newFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
newFrame.setVisible(true);
newFrame.pack();
newFrame.getContentPane().add(battle);
}
}
private class ButtonListener implements ActionListener{
public void actionPerformed(ActionEvent e){
Object source = e.getSource();
if(source == button1){
if(checkPowerAttack() == true){
powerAttack();
}
else
playerDamage = 0;
opponentHealth = opponentHealth - playerDamage;
}
if(source == button2){
if(checkNormalAttack() == true){
normalAttack();
}
else
playerDamage = 0;
opponentHealth = opponentHealth - playerDamage;
}
if(source == button3){
if(checkQuickAttack() == true){
quickAttack();
}
else
playerDamage = 0;
opponentHealth = opponentHealth - playerDamage;
}
if((source == button1 || source == button2) || source == button3){
if(checkOpponentAttack() == true){
opponentAttack();
}
else
opponentDamage = 0;
playerHealth = playerHealth - opponentDamage - levelDamage;
}
if(source == button4){
level++;
opponentHealth = opponentHealth + 25;
maxOpponentHealth = opponentHealth;
}
if(playerHealth <= 0 && opponentHealth > 0){
JOptionPane.showMessageDialog(null,"YOU LOSE");
}
if(opponentHealth <= 0 && playerHealth > 0){
JOptionPane.showMessageDialog(null,"YOU WIN");
}
label1.setText("You : " + Integer.toString(playerHealth) + " / 100");
label2.setText("Opponent : " + Integer.toString(opponentHealth) + " / " + Integer.toString(maxOpponentHealth));
if(playerDamage != 0 && opponentDamage != 0){
label3.setText("You made " + Integer.toString(playerDamage) + " damage to your opponent. " + http://stackoverflow.com/editing-help
"Your opponent give " + Integer.toString(opponentDamage + levelDamage) + " damage to you.");
}
else if(playerDamage == 0 && opponentDamage != 0){
label3.setText("YOU MISSED YOUR ATTACK! " +
"Your opponent give " + Integer.toString(opponentDamage + levelDamage) + " damage to you.");
}
else if(playerDamage != 0 && opponentDamage == 0){
label3.setText("You made " + Integer.toString(playerDamage) + " damage to your opponent. " +
"YOUR OPPONENT MISSED HIS ATTACK!");
}
else if(playerDamage == 0 && opponentDamage == 0){
label3.setText("YOU MISSED YOUR ATTACK! " +
"YOUR OPPONENT ALSO MISSED HIS ATTACK!");
}
}
}
}
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class RPG extends JFrame {
private Board board = new Board();
private Battle battle = new Battle();
public RPG() {
initUI();
}
private void initUI() {
add(board);
setSize(900, 900);
setResizable(false);
setTitle("RPG");
setLocationRelativeTo(null);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
}
public static void main(String[] args) {
EventQueue.invokeLater(new Runnable() {
public void run() {
RPG ex = new RPG();
ex.setVisible(false);
}
});
}
}

Opening a new window is as simple as creating a new frame like you've already done in your display() function. For instance, this:
JFrame newFrame = new JFrame("New Window");
newFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
newFrame.setVisible(true);
Should be enough to open a new window with nothing in it (you'll probably want to add something to it you did in your display() method). Since you want to do this when the player reaches a certain position, just check the player coordinates on movement and call similar code to open a new frame.
EDIT:
Upon looking again, it looks like you can just call display() in your checkBattle() function? It looks like you already have most of the logic here. If you're wondering where to call checkBattle() from, I'd put it in the Player.move() function.

Java creating a new frame

public static void main(String[] arguments){
TicTac frame = new TicTac();
}
The second TicTac says cannot find symbol and asks to create constructor TicTac();.
My constructer is as follows:
public TicTac(TicTac in) {
}
I have tried
TicTac frame = new TicTac(TicTac in);
Here is the whole code:
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;
import javax.swing.*;
import tictactoe.TicTac;
public class TicTac extends JFrame implements ItemListener, ActionListener, Runnable{
TicTac gui;
Thread playing;
TicTacEvent tictac = new TicTacEvent(this);
JPanel row1 = new JPanel();
JButton[][] boxes = new JButton[3][3];
JButton play = new JButton("Play");
JTextField blank1 = new JTextField();
JTextField blank2 = new JTextField();
JOptionPane win = new JOptionPane("Winner");
ImageIcon back = new ImageIcon("cardback.jpg");
ImageIcon a = new ImageIcon("x.jpg");
ImageIcon b = new ImageIcon("o.jpg");
int clicks = 0;
//int win = 0;
int winX = 0;
int winO = 0;
int tie = 0;
int[][] check = new int[3][3];
public TicTac(TicTac in) {
super ("Tic Tac Toe");
gui = in;
setSize (500,600);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
FlowLayout layout = new FlowLayout();
setLayout(layout);
int name = 0;
String newname;
for (int row=0; row<=2;row++){
for(int col=0; col<=2; col++){
check[row][col]=0;
}
}
GridLayout layout1 = new GridLayout(4, 3, 10, 10);
row1.setLayout(layout1);
for (int x=0; x<=2; x++){
for (int y=0; y<=2; y++){
name = name + 1;
newname = Integer.toString(name);
boxes[x][y] = new JButton(newname);
boxes[x][y].setIcon(back);
row1.add(boxes[x][y]);
}
}
row1.add(blank1);
row1.add(play);
row1.add(blank2);
add (row1);
play.addActionListener(tictac);
for (int x=0; x<=2; x++){
for (int y=0; y<=2; y++){
boxes[x][y].addActionListener(tictac);
}
}
setVisible(true);
}
public static void main(String[] arguments){
TicTac frame = new TicTac();
}
public void itemStateChanged(ItemEvent ie) {
throw new UnsupportedOperationException("Not supported yet.");
}
public void actionPerformed(ActionEvent event) {
String command = event.getActionCommand();
if (command.equals("Play")) {
startPlaying();
}
if (command.equals("1")) {
b1();
}
if (command.equals("2")) {
b2();
}
if (command.equals("3")) {
b3();
}
if (command.equals("4")) {
b4();
}
if (command.equals("5")) {
b5();
}
if (command.equals("6")) {
b6();
}
if (command.equals("7")) {
b7();
}
if (command.equals("8")) {
b8();
}
if (command.equals("9")) {
b9();
}
}
void b1() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][0].setIcon(a);
check[0][0] = 1;
} else {
gui.boxes[0][0].setIcon(b);
check[0][0] = 2;
}
winner();
}
void b2() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][1].setIcon(a);
check[0][1] = 1;
} else {
gui.boxes[0][1].setIcon(b);
check[0][1] = 2;
}
winner();
}
void b3() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][2].setIcon(a);
check[0][2] = 1;
} else {
gui.boxes[0][2].setIcon(b);
check[0][2] = 2;
}
winner();
}
void b4() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][0].setIcon(a);
check[1][0] = 1;
} else {
gui.boxes[1][0].setIcon(b);
check[1][0] = 2;
}
winner();
}
void b5() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][1].setIcon(a);
check[1][1] = 1;
} else {
gui.boxes[1][1].setIcon(b);
check[1][1] = 2;
}
winner();
}
void b6() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][2].setIcon(a);
check[1][2] = 1;
} else {
gui.boxes[1][2].setIcon(b);
check[1][2] = 2;
}
winner();
}
void b7() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][0].setIcon(a);
check[2][0] = 1;
} else {
gui.boxes[2][0].setIcon(b);
check[2][0] = 2;
}
winner();
}
void b8() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][1].setIcon(a);
check[2][1] = 1;
} else {
gui.boxes[2][1].setIcon(b);
check[2][1] = 2;
}
winner();
}
void b9() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][2].setIcon(a);
check[2][2] = 1;
} else {
gui.boxes[2][2].setIcon(b);
check[2][2] = 2;
}
winner();
}
void winner() {
/** Check rows for winner */
for (int x=0; x<=2; x++){
if ((check[x][0]==check[x][1])&&(check[x][0]==check[x][2])) {
if (check[x][0]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
winX = 1;
System.out.println(Integer.toString(winX));
blank1.setText("Number of X Wins = " + (Integer.toString(winX)));
} else if (check[x][0]==2){
JOptionPane.showMessageDialog(null, "O is the winner");
winO = 1;
}
}
}
/** Check columns for winner */
for (int x=0; x<=2; x++){
if ((check[0][x]==check[1][x])&&(check[0][x]==check[2][x])) {
if (check[0][x]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
winX = 1;
} else if (check[0][x]==2) {
JOptionPane.showMessageDialog(null, "O is the winner");
winO = 1;
}
}
}
/** Check diagonals for winner */
if (((check[0][0]==check[1][1])&&(check[0][0]==check[2][2]))||
((check[2][0]==check[1][1])&&(check[1][1]==check[0][2]))){
if (check[1][1]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
winX = 1;
} else if (check[1][1]==2) {
JOptionPane.showMessageDialog(null, "O is the winner");
winO = 1;
}
}
/** Checks if the game is a tie */
/* if ((clicks==9) && (win==0)) {
JOptionPane.showMessageDialog(null, "The game is a tie");
}
*/}
void startPlaying() {
playing = new Thread(this);
playing.start();
gui.play.setEnabled(false);
}
public void run() {
throw new UnsupportedOperationException("Not supported yet.");
}
}
To fix my problem I created a separate class.
Class one:
import java.awt.*;
import javax.swing.*;
public class TicTac extends JFrame {
TicTacEvent tictac = new TicTacEvent(this);
JPanel row1 = new JPanel();
JButton[][] boxes = new JButton[3][3];
JButton play = new JButton("Play");
JTextField blank1 = new JTextField();
JTextField blank2 = new JTextField();
JOptionPane win = new JOptionPane("Winner");
ImageIcon back = new ImageIcon("cardback.jpg");
public TicTac() {
super ("Tic Tac Toe");
setSize (500,600);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
FlowLayout layout = new FlowLayout();
setLayout(layout);
int name = 0;
String newname;
GridLayout layout1 = new GridLayout(4, 3, 10, 10);
row1.setLayout(layout1);
for (int x=0; x<=2; x++){
for (int y=0; y<=2; y++){
name = name + 1;
newname = Integer.toString(name);
boxes[x][y] = new JButton(newname);
boxes[x][y].setIcon(back);
row1.add(boxes[x][y]);
}
}
row1.add(blank1);
row1.add(play);
row1.add(blank2);
add (row1);
play.addActionListener(tictac);
for (int x=0; x<=2; x++){
for (int y=0; y<=2; y++){
boxes[x][y].addActionListener(tictac);
}
}
setVisible(true);
}
public static void main(String[] arguments){
TicTac frame = new TicTac();
}
}
Class 2:
import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
public class TicTacEvent implements ItemListener, ActionListener, Runnable {
TicTac gui;
Thread playing;
ImageIcon a = new ImageIcon("x.jpg");
ImageIcon b = new ImageIcon("o.jpg");
int clicks = 0;
int win = 0;
int[][] check = new int[3][3];
public TicTacEvent (TicTac in){
gui = in;
for (int row=0; row<=2; row++){
for (int col=0; col<=2; col++){
check[row][col]=0;
}
}
}
public void actionPerformed (ActionEvent event) {
String command = event.getActionCommand();
if (command.equals("Play")) {
startPlaying();
}
if (command.equals("1")) {
b1();
}
if (command.equals("2")) {
b2();
}
if (command.equals("3")) {
b3();
}
if (command.equals("4")) {
b4();
} if (command.equals("5")) {
b5();
}
if (command.equals("6")) {
b6();
}
if (command.equals("7")) {
b7();
}
if (command.equals("8")) {
b8();
}
if (command.equals("9")) {
b9();
}
}
void b1() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][0].setIcon(a);
check[0][0] = 1;
} else {
gui.boxes[0][0].setIcon(b);
check[0][0] = 2;
}
winner();
}
void b2() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][1].setIcon(a);
check[0][1] = 1;
} else {
gui.boxes[0][1].setIcon(b);
check[0][1] = 2;
}
winner();
}
void b3() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][2].setIcon(a);
check[0][2] = 1;
} else { gui.boxes[0][2].setIcon(b);
check[0][2] = 2;
}
winner();
}
void b4() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][0].setIcon(a);
check[1][0] = 1;
} else {
gui.boxes[1][0].setIcon(b);
check[1][0] = 2;
}
winner();
}
void b5() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][1].setIcon(a);
check[1][1] = 1;
} else {
gui.boxes[1][1].setIcon(b);
check[1][1] = 2;
}
winner();
}
void b6() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][2].setIcon(a);
check[1][2] = 1;
} else {
gui.boxes[1][2].setIcon(b);
check[1][2] = 2;
}
winner();
}
void b7() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][0].setIcon(a);
check[2][0] = 1;
} else {
gui.boxes[2][0].setIcon(b);
check[2][0] = 2; }
winner();
}
void b8() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][1].setIcon(a);
check[2][1] = 1;
} else {
gui.boxes[2][1].setIcon(b);
check[2][1] = 2;
}
winner();
}
void b9() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][2].setIcon(a);
check[2][2] = 1;
} else {
gui.boxes[2][2].setIcon(b);
check[2][2] = 2;
}
winner();
}
void winner() {
/** Check rows for winner */
for (int x=0; x<=2; x++){
if ((check[x][0]==check[x][1])&&(check[x][0]==check[x][2])) {
if (check[x][0]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
win = 1;
} else if (check[x][0]==2){
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
}
}
}
/** Check columns for winner */
for (int x=0; x<=2; x++){
if ((check[0][x]==check[1][x])&&(check[0][x]==check[2][x])) {
if (check[0][x]==1) {
JOptionPane.showMessageDialog(null, "X is the winner"); win = 1;
} else if (check[0][x]==2) {
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
}
}
}
/** Check diagonals for winner */
if (((check[0][0]==check[1][1])&&(check[0][0]==check[2][2]))||
((check[2][0]==check[1][1])&&(check[1][1]==check[0][2]))){
if (check[1][1]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
win = 1;
} else if (check[1][1]==2) {
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
}
}
/** Checks if the game is a tie */
if ((clicks==9) && (win==0)) {
JOptionPane.showMessageDialog(null, "The game is a tie");
}
}
void startPlaying() {
playing = new Thread(this);
playing.start();
gui.play.setEnabled(false);
}
public void itemStateChanged(ItemEvent e) {
throw new UnsupportedOperationException("Not supported yet.");
}
public void run() {
throw new UnsupportedOperationException("Not supported yet.");
}
}

Your constructor requires you to pass in an existing TicTac as a parameter. In the code you show, you're trying to create a TicTac without doing so.
As #MadProgrammer points out, requiring a TicTac to create a TicTac creates something of a catch-22 situation: How can you ever create one without having one first? If, for some reason, you do need to create a TicTac with a reference to an existing TicTac, you need to create an additional constructor with no parameters (as your compiler is suggesting) to create the first one:
public TicTac() { }
(more accurately, your constructor can take parameters, it just cant require a TicTac):
class TicTac {
public TicTac(int size) { }
public TicTac(TicTac otherTicTac) { }
...
}
//elsewhere:
TicTac first = new TicTac(5); //or just TicTac first = new TicTac()
TicTac second = new TicTac(first);
However, I'm guessing that you don't really need a TicTac(TicTac otherTicTac) constructor (if so, tell me why), and that you're trying to do so as a result of a misunderstanding about how constructors work - in which case this might be a helpful read, for starters.

Resetting JPanel in another class file

I have a GUI created in my main class file
import java.awt.*;
import javax.swing.*;
public class TicTac extends JFrame {
TicTacEvent tictac = new TicTacEvent(this);
JPanel row1 = new JPanel();
JButton[][] boxes = new JButton[4][4];
JButton play = new JButton("Play");
JButton restart = new JButton("Restart");
JTextField blank1 = new JTextField();
JTextField blank2 = new JTextField();
JOptionPane win = new JOptionPane("Winner");
ImageIcon back = new ImageIcon("cardback.jpg");
public TicTac() {
super ("Tic Tac Toe");
setSize (800,650);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
FlowLayout layout = new FlowLayout();
setLayout(layout);
int name = 0;
String newname;
GridLayout layout1 = new GridLayout(5, 4, 10, 10);
row1.setLayout(layout1);
for (int x=0; x<=3; x++){
for (int y=0; y<=3; y++){
name = name + 1;
newname = Integer.toString(name);
boxes[x][y] = new JButton(newname);
boxes[x][y].setIcon(back);
row1.add(boxes[x][y]);
}
}
row1.add(blank1);
row1.add(play);
row1.add(blank2);
row1.add(restart);
add (row1);
play.addActionListener(tictac);
for (int x=0; x<=3; x++){
for (int y=0; y<=3; y++){
boxes[x][y].addActionListener(tictac);
}
}
setVisible(true);
}
public static void main(String[] arguments){
TicTac frame = new TicTac();
}
}
And I have code using it here
import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
public class TicTacEvent implements ItemListener, ActionListener, Runnable {
TicTac gui;
Thread playing;
Thread restarting;
ImageIcon a = new ImageIcon("x.jpg");
ImageIcon b = new ImageIcon("o.jpg");
int clicks = 0;
int win = 0;
int winx = 0;
int winy = 0;
int cat = 0;
int[][] check = new int[4][4];
public TicTacEvent (TicTac in){
gui = in;
for (int row=0; row<=3; row++){
for (int col=0; col<=3; col++){
check[row][col]=0;
}
}
}
public void actionPerformed(ActionEvent event){
String command = event.getActionCommand();
if (command.equals("Play")) {
startPlaying();
} else if (command.equals("Restart")) {
restart();
}
if (command.equals("1")) {
b1();
}
if (command.equals("2")) {
b2();
}
if (command.equals("3")) {
b3();
}
if (command.equals("4")) {
b4();
}
if (command.equals("5")) {
b5();
}
if (command.equals("6")) {
b6();
}
if (command.equals("7")) {
b7();
}
if (command.equals("8")) {
b8();
}
if (command.equals("9")) {
b9();
}
if (command.equals("10")) {
b10();
}
if (command.equals("11")) {
b11();
}
if (command.equals("12")) {
b12();
}
if (command.equals("13")) {
b13();
}
if (command.equals("14")) {
b14();
}
if (command.equals("15")) {
b15();
}
if (command.equals("16")) {
b16();
}
gui.blank1.setText("X Wins: " + winx + " Y Wins:" + winy);
gui.blank2.setText("Cat Wins(Tie):" + cat);
}
void b1() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][0].setIcon(a);
check[0][0] = 1;
} else {
gui.boxes[0][0].setIcon(b);
check[0][0] = 2;
}
winner();
}
void b2() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][1].setIcon(a);
check[0][1] = 1;
} else {
gui.boxes[0][1].setIcon(b);
check[0][1] = 2;
}
winner();
}
void b3() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][2].setIcon(a);
check[0][2] = 1;
} else {
gui.boxes[0][2].setIcon(b);
check[0][2] = 2;
}
winner();
}
void b4() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[0][3].setIcon(a);
check[0][3] = 1;
} else {
gui.boxes[0][3].setIcon(b);
check[0][3] = 2;
}
winner();
}
void b5() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][0].setIcon(a);
check[1][0] = 1;
} else {
gui.boxes[1][0].setIcon(b);
check[1][0] = 2;
}
winner();
}
void b6() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][1].setIcon(a);
check[1][1] = 1;
} else {
gui.boxes[1][1].setIcon(b);
check[1][1] = 2;
}
winner();
}
void b7() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][2].setIcon(a);
check[1][2] = 1;
} else {
gui.boxes[1][2].setIcon(b);
check[1][2] = 2;
}
winner();
}
void b8() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[1][3].setIcon(a);
check[1][3] = 1;
} else {
gui.boxes[1][3].setIcon(b);
check[1][3] = 2;
}
winner();
}
void b9() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][0].setIcon(a);
check[2][0] = 1;
} else {
gui.boxes[2][0].setIcon(b);
check[2][0] = 2;
}
winner();
}
void b10() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][1].setIcon(a);
check[2][1] = 1;
} else {
gui.boxes[2][1].setIcon(b);
check[2][1] = 2;
}
winner();
}
void b11() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][2].setIcon(a);
check[2][2] = 1;
} else {
gui.boxes[2][2].setIcon(b);
check[2][2] = 2;
}
winner();
}
void b12() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[2][3].setIcon(a);
check[2][3] = 1;
} else {
gui.boxes[2][3].setIcon(b);
check[2][3] = 2;
}
winner();
}
void b13() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[3][0].setIcon(a);
check[3][0] = 1;
} else {
gui.boxes[3][0].setIcon(b);
check[3][0] = 2;
}
winner();
}
void b14() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[3][1].setIcon(a);
check[3][1] = 1;
} else {
gui.boxes[3][1].setIcon(b);
check[3][1] = 2;
}
winner();
}
void b15() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[3][2].setIcon(a);
check[3][2] = 1;
} else {
gui.boxes[3][2].setIcon(b);
check[3][2] = 2;
}
winner();
}
void b16() {
clicks = clicks + 1;
if ((clicks%2)==1){
gui.boxes[3][3].setIcon(a);
check[3][3] = 1;
} else {
gui.boxes[3][3].setIcon(b);
check[3][3] = 2;
}
winner();
}
public void winner() {
/** Check rows for winner */
for (int x=0; x<=3; x++){
if ((check[x][0]==check[x][1])&&(check[x][0]==check[x][2]) && (check[x][0]== check[x][3])) {
if (check[x][0] ==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
win = 1;
winx +=1;
} else if (check[x][0]==2){
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
winy +=1;
}
}
}
/** Check columns for winner */
for (int x=0; x<=3; x++){
if ((check[0][x]==check[1][x])&&(check[0][x]==check[2][x])&& (check[0][x]== check[3][x])) {
if (check[0][x]==1) {
JOptionPane.showMessageDialog(null, "X is the winner");
win = 1;
winx +=1;
} else if (check[0][x]==2) {
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
winy +=1;
}
}
}
if ((check[1][1]== 1) && (check[3][3] == 1) && (check[2][2]==1) && (check[0][0]==1)
|| (check[3][0]==1) &&(check[1][2]==1) &&(check[0][3]==1))
{
JOptionPane.showMessageDialog(null, "X is the winner");
win = 1;
winx +=1;
} else if ((check[1][1]== 2) && (check[3][3] == 2) && (check[2][2]==2) && (check[0][0]==2)
|| (check[3][0]==2) &&(check[1][2]==2) &&(check[0][3]==2)) {
JOptionPane.showMessageDialog(null, "Y is the winner");
win = 1;
winy +=1;
}
//}
/** Checks if the game is a tie */
if ((clicks==16) && (win==0)) {
JOptionPane.showMessageDialog(null, "The game is a tie");
cat =+1;
}
}
public void startPlaying() {
playing = new Thread(this);
playing.start();
gui.play.setEnabled(false);
}
public void restart() {
TicTac restartok = new TicTac();
restartok.row1.add(restartok.blank1);
restartok.row1.add(restartok.play);
restartok.row1.add(restartok.blank2);
restartok.row1.add(restartok.restart);
restartok.add (restartok.row1);
restartok.play.addActionListener(restartok.tictac);
for (int x=0; x<=3; x++){
for (int y=0; y<=3; y++){
restartok.boxes[x][y].addActionListener(restartok.tictac);
}
}
}
public void itemStateChanged(ItemEvent e) {
// throw new UnsupportedOperationException("Not supported yet.");
}
public void run() {
//restart();
//throw new UnsupportedOperationException("Not supported yet.");
}
}
However my question is how I'd reset the GUI, I have some ideas..
The constructor "Public TicTac" creates the gui, however I am not sure how I'd get to happen again through another classfile. My understanding of OOP is that with a constructor I can call to by creating an object
TicTac restartok = new TicTac();
So assumedly, you'd think I'd be creating another JPanel/GUI everytime I called the restart(); method, no?
My OOP expeirence is limited, so I don't have a clue where to start or find out what logic is incorrect. Thanks.

To reset the game, just reset clicks to 0 and the buttons to their original state just as they were created:
boxes[x][y] = new JButton(newname);
boxes[x][y].setIcon(back);
Apart from that, you have many things to fix in your code. Here are some:
Your line boxes[x][y].addActionListener(tictac); is in a loop of its own where it should be in the initial loop. No reason to iterate twice over the same arrays.
Your layout decisions could be better (depending on what exactly you want to get).
Start the GUI with TicTac frame = new TicTac(); from inside an invokeLater method.
Create an ActionListener for each button with a unique functionality. In your case it's 1 for play, 1 for restart, and 1 for all the board buttons.
You're using event.getActionCommand but you did not call setActionCommand on any of the buttons.
Don't use multiple if when you check for the button pressed (action command name), use if else, or better - use a switch statement.
Don't use a separate function for each button. Use 1 function which receives the button as its argument.
Don't create fields when you can create local variables instead.
If you need clarifications leave a comment.
Edit: here is some modified code that resets the buttons (I couldn't stop myself from correcting other parts of the code, though there is still more to do).
public class TicTac extends JFrame {
static JButton[][] boxes = new JButton[4][4];
static int[][] check = new int[4][4];
static JTextField blank1 = new JTextField();
static JTextField blank2 = new JTextField();
static int turns = 1;
static ImageIcon back = new ImageIcon("cardback.jpg");
static ImageIcon x = new ImageIcon("x.jpg");
static ImageIcon o = new ImageIcon("o.jpg");
public TicTac() {
JPanel gamePanel = new JPanel(new GridLayout(5, 4, 10, 10));
for (int x = 0; x<=3; x++) {
for (int y = 0; y<=3; y++) {
boxes[x][y] = new JButton(""+x+y, back);
boxes[x][y].addActionListener(new XOActionListenr(x, y));
gamePanel.add(boxes[x][y]);
}
}
JButton play = new JButton("Play");
JButton restart = new JButton("Restart");
play.addActionListener(new PlayActionListenr());
restart.addActionListener(new RestartActionListenr());
setLayout(new FlowLayout());
gamePanel.add(blank1);
gamePanel.add(play);
gamePanel.add(blank2);
gamePanel.add(restart);
add(gamePanel);
setTitle("Tic Tac Toe");
pack();
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setVisible(true);
}
private void winner() {
// Check for winner
}
private class XOActionListenr implements ActionListener {
private int row, col;
private XOActionListenr(int row, int col) {
this.row = row;
this.col = col;
}
public void actionPerformed(ActionEvent e) {
if (turns % 2 == 0) {
boxes[row][col].setText("O");
boxes[row][col].setIcon(o);
check[row][col] = 2;
}
else {
boxes[row][col].setText("X");
boxes[row][col].setIcon(x);
check[row][col] = 1;
}
winner();
turns++;
}
}
private class PlayActionListenr implements ActionListener {
public void actionPerformed(ActionEvent e) {
// Not sure why you would need the "play" button at all,
// but insert here what it's supposed to do
}
}
private class RestartActionListenr implements ActionListener {
public void actionPerformed(ActionEvent e) {
for (int x = 0; x<=3; x++) {
for (int y = 0; y<=3; y++) {
boxes[x][y].setText(""+x+y);
boxes[x][y].setIcon(back);
}
}
}
}
public static void main(String[] arguments) {
SwingUtilities.invokeLater(new Runnable() {
public void run() {
new TicTac();
}
});
}
}

You do not need to re-create whole GUI again and again. what you need to do is to clear textfields and whatever selection user has made till now. So you need to create a separate method in which you will reset the state of every button/textfields in your GUI.
for example: to clear textfield you will call setText("") method.
Hope this helps.

Receiving " error: ' void ' type not allowed when checking JButton status in Tic Tac Toe game

I have 9 scenarios making a 9 conditional statement that will look to see if all the my JButton have been pressed and no winner was found, but it is giving me " error: ' void ' type not allowed here.
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
public class TicTacToe extends JFrame
{
private final int HEIGHT = 450;
private final int WIDTH = 500;
private static JButton [] button = new JButton[9];
private static Action [] playerTurn = new Action[9];
private static JLabel [] label;
private int player = 1;
private Font arial = new Font("Arial", Font.BOLD, 20);
private static int lockButtons = 0;
public TicTacToe ()
{
setTitle( " tic tak tow ");
setSize( HEIGHT, WIDTH);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setLayout(new GridLayout(4,3));
int num = 0;
for(int i = 0; i < 9; i++ )
{
button[i] = new JButton( "B" + i + 1);
playerTurn[i] = new Action();
add(button[i]);
button[i].setFont(arial);
button[i].addActionListener(playerTurn[i]);
}
setVisible(true);
}
private class Action implements ActionListener
{
public void actionPerformed(ActionEvent playerMove)
{
//Get button pressed using GetSource Command
JButton whatPlayer=(JButton)(playerMove.getSource());
if(player == 1)
{
player++;
whatPlayer.setText("player1");
whatPlayer.setEnabled(false);
validate();
return;
}
if (player == 2)
{
player--;
whatPlayer.setText("player2");
whatPlayer.setEnabled(false);
validate();
return;
}
}
public void validate()
{
if(button[0].getText().equals(button[1].getText()) && button[1].getText().equals(button[2].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[0].getText());
gameOver();
}
if(button[3].getText().equals(button[4].getText()) && button[4].getText().equals(button[5].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[3].getText());
gameOver();
}
if(button[6].getText().equals(button[7].getText()) && button[7].getText().equals(button[8].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[6].getText());
gameOver();
}
if(button[0].getText().equals(button[3].getText()) && button[3].getText().equals(button[6].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[0].getText());
gameOver();
}
if(button[1].getText().equals(button[4].getText()) && button[4].getText().equals(button[7].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[1].getText());
gameOver();
}
if(button[1].getText().equals(button[4].getText()) && button[4].getText().equals(button[7].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[1].getText());
gameOver();
}
if(button[2].getText().equals(button[5].getText()) && button[5].getText().equals(button[8].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[2].getText());
gameOver();
}
if(button[0].getText().equals(button[4].getText()) && button[4].getText().equals(button[8].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[0].getText());
gameOver();
}
if(button[2].getText().equals(button[4].getText()) && button[4].getText().equals(button[6].getText()))
{
JOptionPane.showMessageDialog(null,"Thank you the winner is" + button[2].getText());
gameOver();
}
if ( button.length == setEnabled(false)) // this is the problem. Don't know if I worded it correctly
{
JOptionPane.showMessageDialog(null,"This was a Draw");
}
}
public void gameOver()
{
for( int x = 0; x < button.length; x++)
{
button[x].setEnabled(false);
}
}
}
public static void main(String[] arg)
{
new TicTacToe();
}
}

button.length will be equal to 9 since you defined an array of 9 elements
private static JButton [] button = new JButton[9];
How can you do this if ( button.length == setEnabled(false)) comparision in if loop,
setEnabled(false) is going to disable the JFrame and the return type is void,here you are comparing the int with void that's why the error is thrown at the compile time.
int i;
for(i=0;i<button.length;i++){
if(b[i].isEnabled()){
break;
}
}
if(i==button.length){
JOptionPane.showMessageDialog(null,"This was a Draw");
}