Develop Reference

Java inheritence and arraylist to sort [closed]

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 3 months ago.
Improve this question
Hey i have a project in which by using inheritence and arraylist i have to take input from file and then show the output after sorting them year wise but in my code my array list's are empty and i am not able to figure out how to solve it.
import java.io.FileNotFoundException;
public class Main {
public static void main(String[] args) throws FileNotFoundException {
// TODO Auto-generated method stub
Driver driver = new Driver();
driver.start();
}
}
import java.util.ArrayList;
import java.util.Scanner;
import javax.swing.JOptionPane;
import java.io.*;
public class Driver {
public void start() throws FileNotFoundException{
// Initialize arraylists
ArrayList<Movie> adventure = new ArrayList<>();
ArrayList<Movie> drama = new ArrayList<>();
ArrayList<Movie> fantasy = new ArrayList<>();
ArrayList<Movie> romance = new ArrayList<>();
ArrayList<Movie> sciFi = new ArrayList<>();
ArrayList<Movie> thriller = new ArrayList<>();
ArrayList<Movie> war = new ArrayList<>();
File myObj = new File("MovieListing.txt");
Scanner myReader = new Scanner(myObj);
String directorName = myReader.nextLine();
String composerName = myReader.nextLine();
while(myReader.hasNextLine()) {
String movie = myReader.nextLine();
String[] movieInfo = movie.split(",");
String title = movieInfo[0];
int year = Integer.parseInt(movieInfo[1]);
String genre = movieInfo[2];
String rating = movieInfo[3];
Movie movie1 = new Movie(title,year,genre,rating,directorName,composerName);
//sort movies into arraylists
if (genre.equals("Adventure"))
{
adventure.add(movie1);
}
else if (genre.equals("Drama"))
{
drama.add(movie1);
}
else if (genre.equals("Fantasy"))
{
fantasy.add(movie1);
}
else if (genre.equals("Romance"))
{
romance.add(movie1);
}
else if (genre.equals("Sci Fi"))
{
sciFi.add(movie1);
}
else if (genre.equals("Thriller"))
{
thriller.add(movie1);
}
else if (genre.equals("War"))
{
war.add(movie1);
}
}
myReader.close();
System.out.print(adventure);
for(Movie movie:war) {
System.out.print(movie.getTitle());
}
// Ask the user which genre they would like to view
String genre = JOptionPane.showInputDialog("Director: " +directorName + "\n" +
"Composer: " + composerName + "\n" +
"Which genre would you like? \n" +
"1. Adventure \n" +
"2. Drama \n" +
"3. Fantasy \n" +
"4. Romance \n" +
"5. SciFi \n" +
"6. Thriller \n" +
"7. War \n" +
"Your choice: ");
// Sort the movies by year released
adventure.sort(new MovieComparator());
drama.sort(new MovieComparator());
fantasy.sort(new MovieComparator());
romance.sort(new MovieComparator());
sciFi.sort(new MovieComparator());
thriller.sort(new MovieComparator());
war.sort(new MovieComparator());
// Display the output dialog box
String output = "Director: " +directorName + "\n" +
"Composer: " +composerName + "\n" +
"Genre: " + genre + "\n" +
"Movie Title\tYear Released\tRating\n";
if (genre.equals("1")) {
for (Movie movie : adventure) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("2")) {
for (Movie movie : drama) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("3")) {
for (Movie movie : fantasy) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("4")) {
for (Movie movie : romance) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("5")) {
for (Movie movie : sciFi) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("6")) {
for (Movie movie : thriller) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
else if (genre.equals("7")) {
for (Movie movie : war) {
output += movie.getTitle() + "\t\t" + movie.getYearReleased() + "\t\t" + movie.getRating() + "\n";
}
}
JOptionPane.showMessageDialog(null, output);
}
}
public class Movie extends Director {
private String title;
private int yearReleased;
private String genre;
private String rating;
public Movie(String title, int yearReleased, String genre, String rating, String directorName, String composerName) {
super(directorName, composerName);
this.title = title;
this.yearReleased = yearReleased;
this.genre = genre;
this.rating = rating;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public int getYearReleased() {
return yearReleased;
}
public void setYearReleased(int yearReleased) {
this.yearReleased = yearReleased;
}
public String getGenre() {
return genre;
}
public void setGenre(String genre) {
this.genre = genre;
}
public String getRating() {
return rating;
}
public void setRating(String rating) {
this.rating = rating;
}
}
public class Director {
private String directorName;
private String composerName;
public Director(String d, String c) {
this.directorName = d;
this.composerName = c;
}
public String getDirectorName() {
return directorName;
}
public void setDirectorName(String directorName) {
this.directorName = directorName;
}
public String getComposerName() {
return composerName;
}
public void setComposerName(String composerName) {
this.composerName = composerName;
}
}
This is the link for the file that needs to be useed in the code https://drive.google.com/file/d/1FkDSAlEv3waby-ML1dKPf3Ouk3S7O99O/view?usp=sharing
Ecpected output format:-
Director: Steven Spielberg
Composer: John Williams
Genre: Drama
Movie Title Year Released Rating
Amistad 1997 R
The Post 2017 PG-13
....

Running your code without any changes throwed an exception:
java.lang.NumberFormatException: For input string: " 1994"
The exception was reported to be caused by this statement in class Driver:
int year = Integer.parseInt(movieInfo[1]);
The reason is quite obvious: There is a leading space infront of 1994, that's why it is throwing that exception. The reason why there is a space infront of 1994 lies within the input file:
Schindler's List, 1994, War, R
The same applies for the "genre" column in the input file and that's the reason why none of the imported movies is associated to the pre-defined genres during import:
if (genre.equals("War")) {
" War" (from import) is different from "War".
You need to remove leading (and trailing) spaces during import. You could do this calling java.lang.String#trim() on item of array movieInfo or by using an appropriate regular expression whith java.lang.String#split(String):
String[] movieInfo = movie.split(",\\s*");
This will split the input line at every occurence of "comma, followed optionally by spaces", effectively removing leading spaces from the imported fields.

How to Pair Up Random Indices of an ArrayList with each other

I am currently working on a project where I read in a CSV file that contains a list of Pokemon, as well as their traits. I am trying to run a battle simulator that randomly pairs up these Pokemon with each other and compares their combatScore, which is a result of a simple calculation using their traits such as speed, attack, defense, etc. I read in all of the Pokemon from the CSV file into an ArrayList of type Pokemon. Now, I want to randomly pair them up with each other and compare their combatScore; whoever has the higher score moves on to the next round, and the loser is placed into another ArrayList of defeated Pokemon. However, I do not know how to randomly pair up the Pokemon. Here is my code of the main class so far:
import java.io.*;
import java.util.ArrayList;
import java.util.Random;
public class assign1 {
public static void main(String[] args) throws IOException {
String csvFile = args[0]; //path to CSV file
String writeFile = args[1]; //name of output file that contains list of Pokemon and their traits
BufferedReader br = null;
String line = "";
String cvsSplitBy = ",";
ArrayList<Pokemon> population = new ArrayList<Pokemon>();
FileWriter fileWriter = new FileWriter(writeFile);
BufferedWriter bufferedWriter = new BufferedWriter(fileWriter);
try {
br = new BufferedReader(new FileReader(csvFile));
String headerLine = br.readLine(); // used to read first line of CSV file that contains headers
while ((line = br.readLine()) != null) {
Pokemon creature = new Pokemon();
// use comma as separator
String[] pokemon = line.split(cvsSplitBy);
creature.setId(pokemon[0]);
creature.setName(pokemon[1]);
creature.setType1(pokemon[2]);
creature.setType2(pokemon[3]);
creature.setTotal(pokemon[4]);
creature.setHp(Integer.parseInt(pokemon[5]));
creature.setAttack(Integer.parseInt(pokemon[6]));
creature.setDefense(Integer.parseInt(pokemon[7]));
creature.setSpAtk(Integer.parseInt(pokemon[8]));
creature.setSpDef(Integer.parseInt(pokemon[9]));
creature.setSpeed(Integer.parseInt(pokemon[10]));
creature.setGeneration(Integer.parseInt(pokemon[11]));
creature.setLegendary(Boolean.parseBoolean(pokemon[12]));
creature.getCombatScore();
// Adds individual Pokemon to the population ArrayList
population.add(creature);
// Writes to pokemon.txt the list of creatures
bufferedWriter.write(creature.getId() + ". "
+ "Name: " + creature.getName() + ": "
+ "Type 1: " + creature.getType1() + ", "
+ "Type 2: " + creature.getType2() + ", "
+ "Total: " + creature.getTotal() + ", "
+ "HP: " + creature.getHp() + ", "
+ "Attack: " + creature.getAttack() + ", "
+ "Defense: " + creature.getDefense() + ", "
+ "Special Attack: " + creature.getSpAtk() + ", "
+ "Special Defense: " + creature.getSpDef() + ", "
+ "Speed: " + creature.getSpeed() + ", "
+ "Generation: " + creature.getGeneration() + ", "
+ "Legendary? " + creature.isLegendary() + ", "
+ "Score: " + creature.getCombatScore());
bufferedWriter.newLine();
}
}
catch (FileNotFoundException e) {
e.printStackTrace();
}
catch (IOException e) {
e.printStackTrace();
}
finally {
if (br != null) {
try {
br.close();
}
catch (IOException e) {
e.printStackTrace();
}
}
}
bufferedWriter.close();
}
}
And here is the code for my Pokemon class:
public class Pokemon {
String id;
String name;
String type1;
String type2;
String total;
int hp;
int attack;
int defense;
int spAtk;
int spDef;
int speed;
int generation;
boolean legendary;
public Pokemon() {}
public String getId () {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public String getType1() {
return type1;
}
public void setType1(String type1) {
this.type1 = type1;
}
public String getType2() {
return type2;
}
public void setType2(String type2) {
this.type2 = type2;
}
public String getTotal() {
return total;
}
public void setTotal(String total) {
this.total = total;
}
public int getHp() {
return hp;
}
public void setHp(int hp) {
this.hp = hp;
}
public int getAttack() {
return attack;
}
public void setAttack(int attack) {
this.attack = attack;
}
public int getDefense() {
return defense;
}
public void setDefense(int defense) {
this.defense = defense;
}
public int getSpAtk() {
return spAtk;
}
public void setSpAtk(int spAtk) {
this.spAtk = spAtk;
}
public int getSpDef() {
return spDef;
}
public void setSpDef(int spDef) {
this.spDef = spDef;
}
public int getSpeed() {
return speed;
}
public void setSpeed(int speed) {
this.speed = speed;
}
public int getGeneration() {
return generation;
}
public void setGeneration(int generation) {
this.generation = generation;
}
public boolean isLegendary() {
return legendary;
}
public void setLegendary(boolean legendary) {
this.legendary = legendary;
}
public int getCombatScore() {
return (speed/2) * (attack + (spAtk/2)) + (defense + (spDef/2));
}
#Override
public String toString() {
return "Name: " + this.getName()
+ ", Type 1: " + this.getType1()
+ ", Type 2: " + this.getType2()
+ ", Total: " + this.getTotal()
+ ", HP: " + this.getHp()
+ ", Attack: " + this.getAttack()
+ ", Defense: " + this.getDefense()
+ ", Sp. Attack: " + this.getSpAtk()
+ ", Sp. Defense: " + this.getSpDef()
+ ", Generation: " + this.getGeneration()
+ ", Legnedary: " + this.isLegendary()
+ ", Score: " + this.getCombatScore();
}
}
I only want to compare their combatScore values to each other. Any help/suggestions would be much appreciated.

What come to my mind is this. You pick one random item (pokemon) from array list. Remove it from array list. Then you pick one random item again and remove it. Now you have a pair of items. Repeat above step for remaining items in array list until no more items available.
Or you can shuffle whole array list first and then pick item i and item i+1 as pair for i=0,2,4,6,...
Collections.shuffle(pokemonsArrayList);
for (int i=0; i< pokemonsArrayList.size(); i+=2) {
pokemon1 = pokemonsArrayList.get(i);
pokemon2 = pokemonsArrayList.get(i+1);
}
Just make sure that number of elements in ArrayList is even. Otherwise code above will throw exception index out of bound

Since every element in an ArrayList has an index, you can just get a random element from it by calling
Pokemon pokemon1;
Pokemon pokemon2;
pokemon1 = arrayList.get(Math.random()*arrayList.size());
do {
pokemon2 = arrayList.get(Math.random()*arrayList.size());
} while(pokemon1.getId() == pokemon2.getId());
then compare the Pokémon you got out of List1 with the one you got from List2.
You can then of course remove the Pokémon from the List if you wish.
Hope that helps you out!

JAVA - Issues Printing ArrayList

I'm currently attempting to make a lottery program through the use of a GUI. I can not figure out why the method getTicketNumbers() is not returning anything. It is simply printing [].
And so too is:
String output = "Name: " + name + "\nNumbers: " + ticketNumbers + "\n\n";
tickNumbers is outputting [] but name successfully prints out the name.
I added a System.out.print to the Ticket class in the constructor to confirm the ArrayList is being passed successfully and it is:
public Ticket(ArrayList<Integer> ticketNumbers, String name) {
this.ticketNumbers = ticketNumbers;
this.name = name;
System.out.print("Are the numbers being passed:" + ticketNumbers + "\n");
}
The method toString is successfully printing the name but again, it is not printing the ArrayList called ticketNumbers.
private void enterLottoButtonActionPerformed(java.awt.event.ActionEvent evt) {
if (nameInput.getText().equalsIgnoreCase("")) {
JOptionPane.showMessageDialog(null, "Please Enter Your Name", "Error", JOptionPane.ERROR_MESSAGE);
} else if (ticketNumbers.size() < 4) {
JOptionPane.showMessageDialog(null, "Please Enter Four Numbers", "Error", JOptionPane.ERROR_MESSAGE);
} else {
ticketList.add(new Ticket(ticketNumbers, nameInput.getText()));
JOptionPane.showMessageDialog(null, "You Successfully Entered! \n\nName: " + nameInput.getText() + "\nNumbers: " + ticketNumbers.toString());
ticketNumbers.clear();
numbersTextField.setText("");
nameInput.setText("");
numberOfPeopleLabel.setText(" People Entered: " + ticketList.size());
}
Ticket Class:
import java.util.ArrayList;
import java.util.Collections;
import javax.swing.JOptionPane;
public class Ticket {
private String name;
private ArrayList<Integer> ticketNumbers = new ArrayList<>();
public Ticket(ArrayList<Integer> ticketNumbers, String name) {
this.ticketNumbers = ticketNumbers;
this.name = name;
System.out.print("Are the numbers being passed:" + ticketNumbers + "\n");
}
public String getName() {
return name;
}
public ArrayList<Integer> getTicketNumbers() {
return ticketNumbers;
}
public ArrayList<Integer> getSortedTicketNumbers() {
Collections.sort(ticketNumbers);
return ticketNumbers;
}
#Override
public String toString() {
String output = "Name: " + name + "\nNumbers: " + ticketNumbers + "\n\n";
return output;
}
}
If needed, code in its entirety:
http://pastebin.com/7i8VWQLk and http://pastebin.com/iRd49Nc7

ticketNumbers.clear()
This line cause the problem. As you said, during the construction of Ticket object, the data been passed in correctly in this line: ticketList.add(new Ticket(ticketNumbers, nameInput.getText()));. But you cleared them afterwards. You will need a clone of ticketList. Regardless of the best practice, you can do it inside Ticket class.
private List<Integer> clonedTicketNumbersList = new ArrayList<Integer>();
public Ticket(ArrayList<Integer> ticketNumbers, String name) {
this.ticketNumbers = ticketNumbers;
this.name = name;
for(Integer ticketNum : ticketNumbers) {
clonedTicketNumbersList.add(ticketNum );
}
System.out.print("Are the numbers being passed:" + ticketNumbers + "\n");
}
#Override
public String toString() {
String output = "Name: " + name + "\nNumbers: " + clonedTicketNumbersList + "\n\n";
return output;
}

It looks like you're copying the reference to the list, and so when you clear it in one place (or modify it) it changes/clears everywhere.
Try making a defensive copy. Like:
ArrayList<Integer> tickets = new ArrayList<>(ticketNumbers)

Null Pointer Exception Error, not sure why

So I had to create a method that separated input string into first/middle/last names, counted the number of "students" created, etc, and then I had to create a class that tested those methods.
public void setName(String newName)
{
String[] nameInput = newName.split(" ");
if(nameInput.length == 0)
{
System.out.println("Error, please enter at least two names.");
newName = null;
}
else if(nameInput.length == 1)
{
firstName = nameInput[0];
middleName = "";
lastName = nameInput[1];
newName = firstName + lastName;
}
else if(nameInput.length == 2)
{
firstName = nameInput[0];
middleName = nameInput[1];
lastName = nameInput[2];
newName = firstName + middleName + lastName;
}
else
{
System.out.println("Error! You can only enter up to three names.");
}
}
public String getName()
{
if (middleName == null)
{
return firstName + " " + lastName;
}
else
return firstName + " " + middleName + " " + lastName;
}
public String getId()
{
return identifier = generateID();
}
#Override
public String toString()
{
return getName() + "\n" + "(" + generateID() + ")";
}
private String generateID()
{
return UUID.randomUUID().toString();
}
and this is the way I am testing the code:
public static void testStudent()
{
System.out.println("Trying to create testStudent1 with a single name...");
testStudent1 = new Student("A");
System.out.println("testStudent1.toString() is " + testStudent1.toString());
System.out.println("testStudent1.getFirstName() is " + testStudent1.getFirstName());
System.out.println("testStudent1.getMiddleName() is " + testStudent1.getMiddleName());
System.out.println("testStudent1.getLastName() is " + testStudent1.getLastName());
System.out.println("Trying to create testStudent2 with two names...");
testStudent1 = new Student("A B");
System.out.println("testStudent2.toString() is " + testStudent2.toString());
System.out.println("testStudent2.getFirstName() is " + testStudent2.getFirstName());
System.out.println("testStudent2.getMiddleName() is " + testStudent2.getMiddleName());
System.out.println("testStudent2.getLastName() is " + testStudent2.getLastName());
System.out.println("Trying to create testStudent3 with three names...");
testStudent1 = new Student("A B C");
System.out.println("testStudent3.toString() is " + testStudent3.toString());
System.out.println("testStudent3.getFirstName() is " + testStudent3.getFirstName());
System.out.println("testStudent3.getMiddleName() is " + testStudent3.getMiddleName());
System.out.println("testStudent3.getLastName() is " + testStudent3.getLastName());
}
I keep running into a null pointer exceptions when it tests toString for a student with 2 names, and I have no clue why.

Edit: The issue is with the testStudent variable in the testStudent() method.
System.out.println("Trying to create testStudent1 with a single name...");
testStudent1 = new Student("A");
System.out.println("testStudent1.toString() is " + testStudent1.toString());
System.out.println("testStudent1.getFirstName() is " + testStudent1.getFirstName());
System.out.println("testStudent1.getMiddleName() is " + testStudent1.getMiddleName());
System.out.println("testStudent1.getLastName() is " + testStudent1.getLastName());
System.out.println("Trying to create testStudent2 with two names...");
Student testStudent2 = new Student("A B");
System.out.println("testStudent2.toString() is " + testStudent2.toString());
System.out.println("testStudent2.getFirstName() is " + testStudent2.getFirstName());
System.out.println("testStudent2.getMiddleName() is " + testStudent2.getMiddleName());
System.out.println("testStudent2.getLastName() is " + testStudent2.getLastName());
System.out.println("Trying to create testStudent3 with three names...");
Student testStudent3 = new Student("A B C");
System.out.println("testStudent3.toString() is " + testStudent3.toString());
System.out.println("testStudent3.getFirstName() is " + testStudent3.getFirstName());
System.out.println("testStudent3.getMiddleName() is " + testStudent3.getMiddleName());
System.out.println("testStudent3.getLastName() is " + testStudent3.getLastName());
Since you are re-using the testStudent1 variable to create a new Object of Student class and not using them to invoke getter functions, it will throw an NPE for testStudent2 and testStudent3 variables.
Answer for old issue: The issue is with your while statement. It will never stop.
You can just find out the count by doing nameInput.length for the String array.
It should be like this:
String[] nameInput = newName.split(" ");
if (nameInput.length == 1)
{
System.out.println("Error, please enter at least two names.");
newName = null;
}
else if (nameInput.length == 2)
{
...
}
else if (nameInput.length == 3)
{
...
}
else
{
...
}

You could use StringTokenizer class to help you with this.
import java.util.StringTokenizer
StringTokenizer test = new StringTokenizer("An example string");
while (test.hasMoreTokens()) {
System.out.println(test.nextToken());
}
Output:
An
example
string.
The countTokens() method can provide how many tokens a string will provide prior processing. That way you will know if you have a middle name or not.

please check trim() method
public static void getName(String newName) {
newName = newName.trim();
String fullName = null;
String[] nameInput = newName.split(" ");
switch (nameInput.length) {
case 2:
fullName = mergeName(nameInput[0], "", nameInput[1]);
break;
case 3:
fullName = mergeName(nameInput[0], nameInput[1], nameInput[2]);
break;
default:
System.out.println("Error, please enter at least two names.");
break;
}
System.out.println(fullName);
}
public static String mergeName(String firstName, String middleName,
String lastName) {
String name = firstName+" " + middleName+" " + lastName;
return name;
}

Check to Determine Which Constructor was Called To Format toString Method

I have the following class and two constructors:
public Book(String bookTitle,ConcurrentHashMap<Integer,String> authors, String bookType ) throws InvalidDataException{
this.setBookTitle(bookTitle);
this.setAuthors(authors);
this.setType(bookType);
}
public Book(String bookTitle,ConcurrentHashMap<Integer,String> authors, String bookType, String bookStyle, String ISBN, int numberofPages) throws InvalidDataException{
this (bookTitle,authors,bookType);
this.fullConstructor = true;
this.setStyle(bookStyle);
this.setISBN(ISBN);
this.setNumberofPages(numberofPages);
}
I also have the following variable:
private Boolean fullConstructor= false; to check which constructor was called.
I did this so that I can properly format my toString() method:
#Override
public String toString() {
String viewOutput="";
if (!this.fullConstructor)
{
viewOutput="Book: " + this.getBookTitle() + " " + " Author(s): " + this.loopAuthors() + " Genre: " + this.bookType;
}
else{
viewOutput="Book: " + this.getBookTitle() + " " + " Author(s): " + this.loopAuthors() + " Genre: " + this.bookType + " Book Style: " + this.getBookStyle() + " ISBN-10: " + this.getISBN() + " Number of Pages: " + this.getNumberofPages() + " Book Style: " +this.getBookStyle() + " ISBN: " + this.getISBN() + "Number of Pages: " + this.getNumberofPages();
}
return viewOutput;
}
Explanation:
If the full constructor is called the private variable fullConstructor is set to true. The toString knows how to format the return value based on the fullConstructor value. I did it this way, because I would have to check again to see what variables are empty, which the setters already do, it seemed repetitive.
Is what I did in bad practice? If so, how do I properly check if the values are empty so that I can correctly create the return string?

I'd probably use this:
public Book(String bookTitle, Map<Integer, String> authors, String bookType, String bookStyle, String isbn, int numberOfPages) throws InvalidDataException {
setBookTitle(bookTitle);
setAuthors(authors);
setType(bookType);
setStyle(bookStyle);
setISBN(isbn);
setNumberOfPages(numberOfPages);
}
public Book(String bookTitle, Map<Integer, String> authors, String bookType) throws InvalidDataException {
this(bookTitle, authors, bookType, null, null, null);
}
#Override
public String toString() {
String result = String.format("Book: %s Author(s): %s Genre: %s",
getBookTitle(), loopAuthors(), bookType);
if (getBookStyle() == null && getISBN() == null && getNumberOfPages() == null)
return result;
return String.format("%s Book Style: %s ISBN-10: %s Number of Pages: %s",
result, getBookStyle(), getISBN(), getNumberOfPages());
}
That way, you don't need a "fully-constructed" flag (seeing as the additional fields have setters and could be called later); the fields are just checked at toString time. Also, I took the liberty of changing your toString method to use String.format, and to be less repetitious.